Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apollo packages to support hooks #5427

Merged
merged 3 commits into from
Aug 7, 2019

Conversation

willopez
Copy link
Member

@willopez willopez commented Aug 6, 2019

Summary

In order to support using hooks to fetch GraphQL data, the Apollo packages needed to be updated. Existing data fetching HOCs can remain as they are,(refactor to use hooks as needed) new fetching code should be implemented using hooks.

Breaking changes

NA

Testing

  1. Start Reaction and do an overview of views that use GraphQL queries or mutations.

@willopez willopez changed the title Willopez upgrade apollo packages Update Apollo packages to support hooks Aug 6, 2019
@willopez willopez marked this pull request as ready for review August 7, 2019 03:23
@willopez willopez added the chore For issues that describe a task that does not affect the release, such as tests or CI configuration label Aug 7, 2019
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Everything seems to work as it was, no changes noticed.

@kieckhafer kieckhafer merged commit 556756c into develop Aug 7, 2019
@kieckhafer kieckhafer deleted the willopez-upgrade-apollo-packages branch August 7, 2019 22:54
@kieckhafer kieckhafer mentioned this pull request Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants