feat: add new setting to allow / disallow custom user locale lookup #5444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…r-customUserLocaleOption
rosshadden
approved these changes
Aug 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #5442 but hopefully with all the commits that weren't being seen in that PR.
Impact: minor
Type: feature|refactor
Issue
When checking a users locale, we hit an external server every time the app refreshes, which can be taxing on performance, and cost.
Solution
Add an option to not allow custom user locales, which will skip this check and use the default store locale. This can be beneficial for any shop which doesn't wish to take the performance hit of the constant external server hit, and also for shops which only have one language / currency and a locale check is not needed.
Breaking changes
None. By default, the old settings of checking the locale are enable.
Testing
Since we don't have an IP address that's locale based when developing locally, the easiest way to test is to
console.loginside of this check, and see that the log shows / doesn't show depending on the settings: https://github.com/reactioncommerce/reaction/blob/refactor-kieckhafer-customUserLocaleOption/imports/plugins/core/core/server/methods/shop/getLocale.js#L57