Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update reaction to use reaction-eslint-rules v2.1.0 #5445

Merged
merged 1 commit into from
Aug 13, 2019
Merged

chore: update reaction to use reaction-eslint-rules v2.1.0 #5445

merged 1 commit into from
Aug 13, 2019

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Aug 13, 2019 •
edited
Loading

Impact: minor
Type: chore

Update Reaction to use the latest version of Reaction ESLint Config, which introduces linting for React Hooks.

Breaking changes

None

Testing

  1. See that the npm package of @reatctioncommerce/esint-config is v2.1.0.
  2. See that eslint-plugin-react-hooks is installed along side as a devDependency
  3. See that the app starts with no errors
  4. See that there are no lint errors (warnings are OK)

willopez
willopez approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kieckhafer kieckhafer merged commit 8cde2ec into develop Aug 13, 2019
@kieckhafer kieckhafer deleted the chore-kieckhafer-updateEslintRulesPackage branch August 13, 2019 20:57
@kieckhafer kieckhafer mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willopez willopez willopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kieckhafer @willopez