test: add integration test for primaryShop query #5459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mia von Steinkirch <[email protected]>
Signed-off-by: Mia von Steinkirch <[email protected]>
von-steinkirch
force-pushed
the
test-mia-primaryShop-integration
branch
from
baec767
to
5d7b59d
Compare
Signed-off-by: Mia von Steinkirch <[email protected]>
von-steinkirch
force-pushed
the
test-mia-primaryShop-integration
branch
from
3321cc0
to
84c16ca
Compare
chrispotter
reviewed
Aug 15, 2019
Signed-off-by: Mia von Steinkirch <[email protected]>
von-steinkirch
force-pushed
the
test-mia-primaryShop-integration
branch
from
3c11ae9
to
b9609fe
Compare
Signed-off-by: Mia von Steinkirch <[email protected]>
von-steinkirch
force-pushed
the
test-mia-primaryShop-integration
branch
from
6ad9cf7
to
ada23e5
Compare
|
@focusaurus According to this https://docs.reactioncommerce.com/docs/graphql-intro#your-first-authenticated-query, I think this query does not require authentication (and tests for it) |
|
Yes, that's correct. I was just trying to provide broad guidance. No need
to test auth if the query is public.
…On Thu, Aug 15, 2019 at 3:15 PM Mia von Steinkirch ***@***.***> wrote:
@focusaurus <https://github.com/focusaurus> According to this
https://docs.reactioncommerce.com/docs/graphql-intro#your-first-authenticated-query,
I think this query does not require authentication (and tests for it)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5459?email_source=notifications&email_token=AADVYSJC4KA6P7V36F33TXDQEXBNRA5CNFSM4IL226BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4NATLY#issuecomment-521800111>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADVYSLBE2XRL5D26TY3XWLQEXBNRANCNFSM4IL226BA>
.
|
aldeed
approved these changes
Aug 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5374
Impact: minor
Type: test
This PR adds an integration test for
primaryShopquery.Testing Instructions