Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update vulnerable packages #5470

Merged
merged 1 commit into from
Aug 20, 2019
Merged

chore: update vulnerable packages #5470

merged 1 commit into from
Aug 20, 2019

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Aug 20, 2019

Impact: minor
Type: chore

Changes

Run npm audit fix to update vulnerable NPM packages.

Breaking changes

None

Testing

Verify the app still starts and works with some basic smoke tests.

@aldeed aldeed self-assigned this Aug 20, 2019
@aldeed aldeed requested a review from kieckhafer August 20, 2019 21:56
kieckhafer
kieckhafer approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 everything works in the same fashion as it was. Good to go, pending CI passing.

@kieckhafer kieckhafer merged commit 838954a into develop Aug 20, 2019
@kieckhafer kieckhafer deleted the chore-aldeed-npm-audit-fix branch August 20, 2019 22:33
@kieckhafer kieckhafer mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieckhafer kieckhafer kieckhafer approved these changes

Assignees

@aldeed aldeed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aldeed @kieckhafer