Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update comp-lib to fix broken components #5475

Merged
merged 1 commit into from
Aug 22, 2019
Merged

fix: update comp-lib to fix broken components #5475

merged 1 commit into from
Aug 22, 2019

Conversation

mikemurray
Copy link
Member

@mikemurray mikemurray commented Aug 22, 2019 •
edited
Loading

Resolves #5460
Impact: critical
Type: bugfix

Issue

Cannot open some admin panels because _objectSpread is not available.

Solution

  • Updated babel libs in component-library and published a new package
  • Update Reaction to use the new component-library package

Breaking changes

none

Testing

Ensure EVERY page loads and works in the admin. Especially the ones that use the component-library, like...

  • Tags
  • Shipping

willopez
willopez approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified all pages load correctly.

@mikemurray mikemurray merged commit 8e1ef03 into develop Aug 22, 2019
@mikemurray mikemurray deleted the fix-5460-mikemurray-update-comp-lib branch August 22, 2019 22:07
@kieckhafer kieckhafer mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willopez willopez willopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikemurray @willopez