-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move legacy permissions into npm package #6096
Merged
kieckhafer
merged 9 commits into
trunk
from
feat-kieckhafer-moveLegacyPermissionsIntoNPMPackage
Feb 12, 2020
Merged
feat: move legacy permissions into npm package #6096
kieckhafer
merged 9 commits into
trunk
from
feat-kieckhafer-moveLegacyPermissionsIntoNPMPackage
Feb 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hier own project. Signed-off-by: Erik Kieckhafer <[email protected]>
…ackage Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
kieckhafer
changed the title
Feat kieckhafer move legacy permissions into npm package
feat: move legacy permissions into npm package
Feb 8, 2020
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
mikemurray
approved these changes
Feb 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The license issue being called out by SNYK has been looked at, and we are OK to merge with the error being thrown. |
kieckhafer
deleted the
feat-kieckhafer-moveLegacyPermissionsIntoNPMPackage
branch
February 12, 2020 22:19
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: major|minor (minor code changes, major impact as we move plugins to npm)
Type: feature
This PR is the first of many which will move our internal plugins to be externally installed npm packages.
This PR removes the
legacy-authorization
plugin code from the API, and installs the@reactioncommerce/plugin-simple-authorization
to perform the same functions.Breaking changes
None
Testing
The authorization code is the same as it was before, it's just being installed from a different place, so you should see nothing different in the behavior of this PR and the
v3.0.0
release it was created from.Once this PR is merged, we should do a
3.1
release alongside this PR inapi-migrations