Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move legacy permissions into npm package #6096

Merged
merged 9 commits into from
Feb 12, 2020

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Feb 7, 2020

Impact: major|minor (minor code changes, major impact as we move plugins to npm)
Type: feature

This PR is the first of many which will move our internal plugins to be externally installed npm packages.

This PR removes the legacy-authorization plugin code from the API, and installs the @reactioncommerce/plugin-simple-authorization to perform the same functions.

Breaking changes

None

Testing

The authorization code is the same as it was before, it's just being installed from a different place, so you should see nothing different in the behavior of this PR and the v3.0.0 release it was created from.

  1. Start the API
  2. Create a user
  3. Create a shop
  4. Click around and see that you have permission to do what you should be able to , as the first user
  5. create a second user
  6. see that you can't perform actions a "regular" user shouldn't be able to

Once this PR is merged, we should do a 3.1 release alongside this PR in api-migrations

@kieckhafer kieckhafer changed the title Feat kieckhafer move legacy permissions into npm package feat: move legacy permissions into npm package Feb 8, 2020
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kieckhafer
Copy link
Member Author

The license issue being called out by SNYK has been looked at, and we are OK to merge with the error being thrown.

@kieckhafer kieckhafer merged commit 2a4f9a4 into trunk Feb 12, 2020
@kieckhafer kieckhafer deleted the feat-kieckhafer-moveLegacyPermissionsIntoNPMPackage branch February 12, 2020 22:19
@kieckhafer kieckhafer mentioned this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants