-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: The Federation #6100
feat: The Federation #6100
Conversation
Signed-off-by: Mike Murray <[email protected]>
Subscriptions are not currently compatible with Apollo Server 2.x Signed-off-by: Mike Murray <[email protected]>
Subscriptions are not currently compatible with Apollo Server 2.x Signed-off-by: Mike Murray <[email protected]>
Subscriptions are not currently compatible with Apollo Server 2.x Signed-off-by: Mike Murray <[email protected]>
Subscriptions are not currently compatible with Apollo Server 2.x Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Put back into WIP to see if there are options to make this not a breaking change. |
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as it's expected to.
API & Gateway work when the correct env
vars are set.
API works as expected when no env
s are set
API gives you a warning when env
s are set incorrectly
One "issue", which is expected here, is that Authenticated queries and mutations do not work through the Gateway. They continue to work through the API directly even when Gateway is enabled, so I see this as OK to merge. @rosshadden thoughts on that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay to merge. We will have to figure out authorization but it's not a blocker for merging this as it will not affect our existing workflow.
I changed the "breaking" in the OP to match latest changes. |
Resolves #6099
Impact: major
Type: feature
Issue
The Reaction API must be a participant in the (Apollo) federation gateway
Solution
Follow steps as outlined by the Apollo docs to make Reaction a participant, which lead to...
.graphql
filesBreaking changes
GraphQL subscriptions will not work. It is not compatible with apollo-server 2.x. It may make a re-appearance in apollo-server 3.0, whenever that's released.Schema stitching has been removed. It is not compatible with federation.Backwards compatibility over breaking changes
Reaction API will run like it always has with
GQL subscriptions
andschema stitching
enabled by default.If you want Apollo Federation support, then you will sacrifice the above two features. You'll have to enable federation and disable subscriptions to get the full federation support in the federated gateway.
Testing
auth token might not yet be supported for requests through the gateway
Error: Subscriptions are not supported with Apollo Federation. Set
REACTION_GRAPHQL_SUBSCRIPTIONS_ENABLED=falseto disable subscriptions.