-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add updateProductsVisibility mutation #6104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Lopez <[email protected]>
Signed-off-by: Will Lopez <[email protected]>
…ce/reaction into feat-bulk-update-products
mikemurray
requested changes
Feb 19, 2020
src/core-services/product/mutations/updateProductsVisibility.js
Outdated
Show resolved
Hide resolved
src/core-services/product/mutations/updateProductsVisibility.js
Outdated
Show resolved
Hide resolved
mikemurray
previously requested changes
Feb 19, 2020
src/core-services/product/mutations/updateProductsVisibility.js
Outdated
Show resolved
Hide resolved
@willopez This needs an integration test as well. |
Signed-off-by: Will Lopez <[email protected]>
Signed-off-by: Will Lopez <[email protected]>
Signed-off-by: Will Lopez <[email protected]>
…ce/reaction into feat-bulk-update-products
ready for another review |
Signed-off-by: Will Lopez <[email protected]>
mikemurray
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6102
Impact: minor
Type: feature
Summary
Adds
updateProductsVisibility
mutation that will update multiple products by setting their visibility property.Breaking changes
None
Testing
isVisible
property on multiple products.