-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move system information plugin to npm #6105
Merged
kieckhafer
merged 6 commits into
trunk
from
refactor-kieckhafer-moveSystemInformationPluginToNPM
Feb 20, 2020
Merged
refactor: move system information plugin to npm #6105
kieckhafer
merged 6 commits into
trunk
from
refactor-kieckhafer-moveSystemInformationPluginToNPM
Feb 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…internal package Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
willopez
requested changes
Feb 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, just a minor comment.
Signed-off-by: Erik Kieckhafer <[email protected]>
@willopez comment addressed |
willopez
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
kieckhafer
deleted the
refactor-kieckhafer-moveSystemInformationPluginToNPM
branch
February 20, 2020 19:37
This was referenced Feb 26, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: refactor
This PR removes the
system-info
plugin code from the API, and installs the@reactioncommerce/plugin-system-information
to perform the same functions.Breaking changes
None
Testing
The system information code is the same as it was before, it's just being installed from a different place, so you should see nothing different in the behavior of this PR and the
v3.1.0
release it was created from.systemInformation
GraphQL query to query system information