Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace internal authentication plugin with NPM installed plugin-authentication #6108

Merged
merged 10 commits into from
Feb 26, 2020

Conversation

kieckhafer
Copy link
Member

Impact: minor
Type: refactor

This PR removes the authentication plugin code from the API, and installs the @reactioncommerce/plugin-authentication to perform the same functions.

Breaking changes

None

Testing

The authentication code is the same as it was before, it's just being installed from a different place, so you should see nothing different in the behavior of this PR and the v3.1.0 release it was created from.

  1. Start the API
  2. Create a user
  3. Create a shop
  4. See that you can reset your password. The mutations here are meant to be internally called, so you need to reset through Identity.

Copy link
Contributor

@focusaurus focusaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. If you want me to test locally mention me again and I'll allocate 30m to do it, but I haven't had a full system running locally recently so it's not super fast for me to test.

Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants