Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: npm discount codes #6157

Merged
merged 9 commits into from
Mar 25, 2020
Merged

Conversation

spencern
Copy link
Contributor

Resolves #6123
Impact: minor
Type: feature|refactor

Issue

Move Discount Codes plugin to npm.

Solution

Created npm package for discount code plugin
https://www.npmjs.com/package/@reactioncommerce/plugin-discount-codes

Testing

  1. Run reaction in dev mode with this branch
  2. Create at least one discount code via Reaction Admin
  3. Using GraphQL playground and a valid authorization code with the admin role run a discount codes query such as this:
{
  discountCodes(shopId: "Your Shop Id") {
    nodes {
      _id
      discount
      transactions {
        cartId
      }
      discountMethod
      description
    }
  }
}
  1. Ensure you see discount code data returned

@spencern spencern changed the title Spencer feat npm discount codes feat: npm discount codes Mar 24, 2020
@spencern spencern changed the title feat: npm discount codes refactr: npm discount codes Mar 24, 2020
@spencern spencern changed the title refactr: npm discount codes refactor: npm discount codes Mar 24, 2020
@spencern
Copy link
Contributor Author

Snyk license checks will fail because this PR introduces a new GPLv3 dependency. This is expected and we can merge anyway

Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@kieckhafer kieckhafer merged commit e8d97fb into trunk Mar 25, 2020
@kieckhafer kieckhafer deleted the spencer-feat-npm-discount-codes branch March 25, 2020 01:17
@kieckhafer kieckhafer mentioned this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move discount-codes plugin to its own npm package, and install npm version Reaction
2 participants