Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate bin/token script #6183

Merged
merged 3 commits into from
Apr 1, 2020
Merged

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Apr 1, 2020

Impact: minor
Type: feature

Changes

The bin/token script now prints a message instead of installing packages and running the getAuthToken.js script.

Please globally install the @reactioncommerce/hydra-token package:

https://www.npmjs.com/package/@reactioncommerce/hydra-token

Then run 'hydra-token get' command instead of 'bin/token'

Breaking changes

None

Testing

Run bin/token 123 and verify that you see the message.

Signed-off-by: Eric Dobbertin <[email protected]>
@aldeed aldeed requested a review from focusaurus April 1, 2020 12:59
focusaurus
focusaurus previously approved these changes Apr 1, 2020
@focusaurus
Copy link
Contributor

Does this count as breaking? Should we run hydra-token get via npx so it's still "here's your token, but also here's the new way?"

@aldeed
Copy link
Contributor Author

aldeed commented Apr 1, 2020

@focusaurus I would not consider this breaking, but your idea is good anyway. How's this? 15a2884

@aldeed aldeed requested a review from focusaurus April 1, 2020 16:06
@aldeed
Copy link
Contributor Author

aldeed commented Apr 1, 2020

@focusaurus Can you approve? It removed your previous approval when I pushed, and I can't merge without an approval.

@focusaurus focusaurus merged commit ca55710 into trunk Apr 1, 2020
@focusaurus focusaurus deleted the feat-aldeed-deprecate-bin-token branch April 1, 2020 16:27
@kieckhafer kieckhafer mentioned this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants