Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move taxes-flat-rate plugin to npm #6198

Merged
merged 6 commits into from
Apr 24, 2020

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Apr 14, 2020

Resolves #6139

This PR removes the internal taxes-rates plugin, and installs the new api-plugin-taxes-flat-rate as a replacement.

The code in that npm plugin is the same, so the expected outcome of this PR is seeing nothing different than how the app currently runs.

@kieckhafer kieckhafer changed the title [BLOCKED] refactor: move flat rate taxes plugin to npm [BLOCKED] refactor: move taxes-flat-rate plugin to npm Apr 15, 2020
@mpaktiti mpaktiti marked this pull request as ready for review April 23, 2020 14:17
@mpaktiti mpaktiti self-requested a review April 23, 2020 14:17
@kieckhafer kieckhafer requested a review from aldeed April 23, 2020 23:16
@kieckhafer kieckhafer changed the title [BLOCKED] refactor: move taxes-flat-rate plugin to npm refactor: move taxes-flat-rate plugin to npm Apr 23, 2020
kieckhafer and others added 2 commits April 23, 2020 16:21
@aldeed aldeed self-assigned this Apr 23, 2020
@aldeed aldeed merged commit 0497f2e into trunk Apr 24, 2020
@aldeed aldeed deleted the refactor-kiekchafer-moveTaxesRatesPlugin branch April 24, 2020 00:42
@kieckhafer kieckhafer mentioned this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move taxes-rates plugin to its own npm package, and install npm version Reaction
2 participants