Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move email plugin to npm #6200

Merged
merged 5 commits into from
Apr 21, 2020
Merged

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Apr 15, 2020

Resolves #6171

This PR removes the internal email plugin, and installs the new api-plugin-email as a replacement.

The code in that npm plugin is the same, so the expected outcome of this PR is seeing nothing different than how the app currently runs.

@kieckhafer kieckhafer changed the title [BLOCKED] refactor: move email plugin to npm [BLOCKED] refactor: move email plugin to npm Apr 15, 2020
@aldeed aldeed changed the title [BLOCKED] refactor: move email plugin to npm refactor: move email plugin to npm Apr 20, 2020
@aldeed aldeed self-requested a review April 20, 2020 23:17
@aldeed aldeed marked this pull request as ready for review April 21, 2020 00:31
@aldeed aldeed merged commit 108c48d into trunk Apr 21, 2020
@aldeed aldeed deleted the refactor-kieckhafer-moveEmailPlugin branch April 21, 2020 00:39
@kieckhafer kieckhafer mentioned this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move email plugin to its own npm package, and install npm version Reaction
2 participants