Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use npm package for tags plugin #6212

Merged
merged 5 commits into from
Apr 17, 2020

Conversation

mpaktiti
Copy link
Contributor

Resolves #6181

This PR removes the internal tags plugin, and installs the new api-plugin-tags from npm as a replacement.

The code in that npm plugin is the same, so the expected outcome of this PR is seeing nothing different than how the app currently runs.

Testing

  • Start reaction, see that tags is the correct version in the systemInformation query
  • Test the tags queries/mutations and see that they work

Signed-off-by: Maria Paktiti [email protected]

Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kieckhafer kieckhafer merged commit 994932d into trunk Apr 17, 2020
@kieckhafer kieckhafer deleted the refactor-mpaktiti-tags-plugin branch April 17, 2020 22:51
@kieckhafer kieckhafer mentioned this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move tags plugin to its own npm package, and install npm version Reaction
2 participants