Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move orders plugin to NPM #6214

Merged
merged 4 commits into from
Apr 20, 2020
Merged

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Apr 20, 2020

Resolves #6175

Removes the internal orders plugin, and installs the new api-plugin-orders as a replacement.

The code in that npm plugin is the same, so the expected outcome of this PR is seeing nothing different than how the app currently runs.

mpaktiti
mpaktiti previously approved these changes Apr 20, 2020
Copy link
Contributor

@mpaktiti mpaktiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placed an order, works fine 👍

@mpaktiti mpaktiti merged commit 734adfe into trunk Apr 20, 2020
@mpaktiti mpaktiti deleted the refactor-aldeed-moveOrdersPlugin branch April 20, 2020 23:12
@kieckhafer kieckhafer mentioned this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move orders plugin to its own npm package, and install npm version Reaction
2 participants