Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move discounts plugin to NPM package #6216

Merged
merged 4 commits into from
Apr 22, 2020

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Apr 20, 2020

Resolves #6170

Removes the internal discounts plugin, and installs the new api-plugin-discounts as a replacement.

The code in that npm plugin is the same, so the expected outcome of this PR is seeing nothing different than how the app currently runs.

Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kieckhafer kieckhafer merged commit d475e44 into trunk Apr 22, 2020
@kieckhafer kieckhafer deleted the refactor-aldeed-moveDiscountsPlugin branch April 22, 2020 01:15
@kieckhafer kieckhafer mentioned this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move discounts plugin to its own npm package, and install npm version Reaction
2 participants