Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move shipments plugin to NPM package #6224

Merged
merged 5 commits into from
Apr 23, 2020

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Apr 22, 2020

Resolves #6179

Removes the internal shipping plugin, and installs the new api-plugin-shipments as a replacement.

The code in that npm plugin is the same, so the expected outcome of this PR is seeing nothing different than how the app currently runs.

@aldeed aldeed changed the title refactor: move shipments plugin to NPM package [BLOCKED] refactor: move shipments plugin to NPM package Apr 22, 2020
@kieckhafer
Copy link
Member

@aldeed I merged #6223, and then pulled trunk into this branch and am still seeing some CI issues.

@aldeed aldeed changed the title [BLOCKED] refactor: move shipments plugin to NPM package refactor: move shipments plugin to NPM package Apr 23, 2020
Signed-off-by: Eric Dobbertin <[email protected]>
to fix plugin name

Signed-off-by: Eric Dobbertin <[email protected]>
@aldeed
Copy link
Contributor Author

aldeed commented Apr 23, 2020

@kieckhafer Should be good now, and I bumped catalog and surcharge plugins for the name fixes

Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kieckhafer kieckhafer merged commit 51f2636 into trunk Apr 23, 2020
@kieckhafer kieckhafer deleted the refactor-aldeed-moveShipmentsPlugin branch April 23, 2020 22:26
@kieckhafer kieckhafer mentioned this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move shipping plugin to its own npm package, and install npm version Reaction
2 participants