-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused npm packages #6229
Conversation
Signed-off-by: Erik Kieckhafer <[email protected]>
@aldeed a few questions about other packages:
|
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I discovered the other day that
graphql
package is similar toreact
in that it can cause errors if there are two different versions installed. So I'm now thinking maybegraphql
should be switched to be a peer dependency in theapi-core
package, rather then a regular dep. So if we do that, thengraphql
should remain installed in this repo. - lodash is used in
jsdoc
folder, but there is no point to building jsdoc docs anymore since this repo has very little code. So I suggest delete.reaction/jsdoc
folder, search for and delete anything else related tojsdoc
, and then also get rid oflodash
. - I think you're correct that mocked package doesn't need to be listed, but not sure either. If you remove it and tests still pass, then I'd say we're good.
Also, it looks to me like faker
, graphql-tools
, and node-fetch
can be moved to devDependencies because only test files import them, and sharp
is unused and can be removed. Only semver
and the @reactioncommerce
packages are needed in dependencies
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
|
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
@kieckhafer node_modules/sharp should continue to exist in the production image as long as any of the plugin packages depend on it. I'd say go ahead and remove it entirely, and after this is merged and we get a new Docker image build for trunk, we'll be able to run and verify that I'm correct. If I'm not, easy to add back before the next release. |
Signed-off-by: Eric Dobbertin <[email protected]>
Removed the direct dependency on |
Many packages we used to need to install in the core api are no longer needed, as they are installed in each plugin instead. This PR removed the unneeded npm installations.
Removed packages:
@reactioncommerce/reaction-error
accounting-js
envalid
graphql
handlebars
later
ramda
simple-schema
Testing
npm lint
should tell you if any plugins are missing