Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy plugins.json into prod image #6244

Merged
merged 1 commit into from
May 5, 2020

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented May 5, 2020

Resolves #6243
Impact: critical
Type: bugfix

Issue

The reactioncommerce/reaction:3.7.0 tag of the API Docker image won't start because one new file wasn't copied into it when it was built.

Solution

Update Dockerfile to copy plugins.json into the image.

Breaking changes

None

Testing

  1. docker-compose down
  2. Delete docker-compose.override.yml in this project if there is one.
  3. Check out this branch
  4. docker-compose up -d
  5. docker-compose logs -f api and see the error from the bug report
  6. docker-compose down
  7. docker build -t reactioncommerce/reaction:3.7.0 . (there's a period at the end of this command)
  8. docker-compose up -d
  9. docker-compose logs -f api and verify the API started without error
  10. docker-compose down

@focusaurus focusaurus merged commit caa96e6 into trunk May 5, 2020
@aldeed aldeed deleted the fix-copy-plugins-json-to-image branch May 5, 2020 17:53
@kieckhafer kieckhafer mentioned this pull request May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile broken - Cannot find module /usr/local/src/app/plugins.json
2 participants