chore: updated api plugins #6265
Conversation
Signed-off-by: Ross Hadden <[email protected]>
package.json
Outdated
| "@reactioncommerce/api-plugin-pricing-simple": "~1.0.1", | ||
| "@reactioncommerce/api-plugin-products": "~1.0.1", | ||
| "@reactioncommerce/api-plugin-settings": "~1.0.1", | ||
| "@reactioncommerce/api-plugin-shipments-flat-rate": "~1.0.1", |
There was a problem hiding this comment.
@rosshadden The problem is with this line, if I set it to "@reactioncommerce/api-plugin-shipments-flat-rate": "~1.0.0" locally it passes the failing tests.
We can either wait until we fix this, or rollback this update only and merge the rest.
There was a problem hiding this comment.
Good find! I bet it was time-consuming. I'll just change this PR to keep that package at the version you found to work.
There was a problem hiding this comment.
@mpaktiti I tried both ~1.0.0 and 1.0.0, but the tests are still failing. Can you play with making your changes to this branch and try to get it working in CI?
There was a problem hiding this comment.
I set it to 1.0.0 and rebuilt the lock file, tests are passing now ¯_(ツ)_/¯
I'll register an issue at the plugin's repo (with a note to update this repo's package.json) and look into it.
rosshadden
force-pushed
the
chore-update-deps
branch
from
74ca26e
to
4e465f0
Compare
Signed-off-by: Ross Hadden <[email protected]>
rosshadden
force-pushed
the
chore-update-deps
branch
from
4e465f0
to
088ac62
Compare
Signed-off-by: Maria Paktiti <[email protected]>
|
Issue for the broken dependency reactioncommerce/api-plugin-shipments-flat-rate#5 |
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
|
@mpaktiti I added fixes, some to this PR, one for shipments based on your ticket, and one for API utils which should address some, hopefully all of broken integration tests. |
Signed-off-by: Maria Paktiti <[email protected]>
|
Looks good @mikemurray, thanks! I updated both packages to latest and all tests pass. |
Updates API plugins.