Update @reactioncommerce dependencies #6296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Loan Laux <[email protected]>
mpaktiti
requested changes
Oct 12, 2020
There was a problem hiding this comment.
Thank you for this @loan-laux! I left a couple of comments regarding the semver ranges.
package.json
Outdated
| @@ -21,47 +21,47 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@reactioncommerce/api-core": "~1.4.0", | |||
| "@reactioncommerce/api-plugin-accounts": "~1.4.4", | |||
| "@reactioncommerce/api-plugin-address-validation-test": "~1.0.0", | |||
| "@reactioncommerce/api-plugin-accounts": "^1.5.0", | |||
There was a problem hiding this comment.
Can you change this to use a tilde ~ range like the rest?
package.json
Outdated
| "@reactioncommerce/api-plugin-authentication": "~1.2.0", | ||
| "@reactioncommerce/api-plugin-authorization-simple": "~1.3.0", | ||
| "@reactioncommerce/api-plugin-authorization-simple": "^1.3.1", |
There was a problem hiding this comment.
Same as above, we should use a tilde range like the rest of the dependencies.
Signed-off-by: Loan Laux <[email protected]>
|
Thanks for catching that @mpaktiti. I'm used to using |
mpaktiti
approved these changes
Oct 14, 2020
|
Thanks @mpaktiti. Would be amazing if we could get a minor release for this one! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Loan Laux [email protected]
Impact: minor
Type: chore
Issue
@reactioncommerce/api-plugin-accountsand@reactioncommerce/api-plugin-authorization-simpleare outdated.Solution
Update the packages to their latest versions.
Breaking changes
None.