Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark @reactioncommerce dependencies for auto minor updates #6330

Merged
merged 5 commits into from
Jun 23, 2021

Conversation

loan-laux
Copy link
Collaborator

Signed-off-by: Loan Laux [email protected]

Resolves #6328
Impact: critical
Type: chore

Please see #6328 for initial discussion. This PR would allow auto minor updates on all @reactioncommerce production dependencies.

@Akarshit
Copy link
Contributor

Akarshit commented Jun 1, 2021

I will keep this PR sitting for a while. Basically I am waiting for the release of v4.0 and just get more discussion/validation around this.

@loan-laux
Copy link
Collaborator Author

Sure @Akarshit. That's what I intended this one for!

@Akarshit
Copy link
Contributor

Akarshit commented Jun 1, 2021

@loan-laux I got the green flag to do this as part of v4.0

@Akarshit
Copy link
Contributor

Akarshit commented Jun 1, 2021

@loan-laux I see that the tests are failing in this one. They shouldn't be but I suppose there is some change in a plugin that wasn't scrutinized properly causing this.
Would it be possible to update the tests along with this PR so that we have a working branch.

@loan-laux
Copy link
Collaborator Author

@Akarshit I've fixed the query tests, but the mutation tests keep failing. It's weird because they complain about the shop type being required as part of CreateShopInput, but:

  1. We pass a type value in these tests anyways
  2. The type is not required in the GraphQL schema

So I'm a bit puzzled here. Don't have more time today to dive in but I'll come back to it soon. Let me know if you have any thoughts on what's happening here. I'm sure it's something simple I'm missing.

@loan-laux
Copy link
Collaborator Author

I see that there's a step in the CI/CD pipeline that restores cache for node_modules from a previous build... Is that the case? And if so, can we disable that and make sure that the dependencies are re-installed every time? Pretty sure these createShop tests are failing because the CI doesn't have the latest version of the api-plugin-shops package.

@Akarshit
Copy link
Contributor

I will get this fixed today.

@Akarshit
Copy link
Contributor

Akarshit commented Jun 15, 2021

Looks like reactioncommerce/api-plugin-shops#30 should fix this.

@loan-laux
Copy link
Collaborator Author

@Akarshit I re-ran the build and we're still getting the same error. Pretty sure there's a caching issue with CircleCI, on top of that problem you've fixed with the shop plugin. Is there any way to force it to reinstall the dependencies at every build?

@Akarshit
Copy link
Contributor

I think we need to remove the cache so that all the PRs are tested with the latest version of plugin. That change should be a part of this PR.

Akarshit
Akarshit previously approved these changes Jun 23, 2021
@Akarshit Akarshit merged commit bb373f3 into reactioncommerce:trunk Jun 23, 2021
@Akarshit Akarshit deleted the outgrow-auto-update-deps branch June 23, 2021 19:39
@rc-publisher
Copy link
Collaborator

🎉 This PR is included in version 3.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rc-publisher rc-publisher added the released Applied automatically by semantic-release label Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Applied automatically by semantic-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let plugins feat update happen automatically.
3 participants