-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark @reactioncommerce
dependencies for auto minor updates
#6330
Mark @reactioncommerce
dependencies for auto minor updates
#6330
Conversation
Signed-off-by: Loan Laux <[email protected]>
I will keep this PR sitting for a while. Basically I am waiting for the release of v4.0 and just get more discussion/validation around this. |
Sure @Akarshit. That's what I intended this one for! |
@loan-laux I got the green flag to do this as part of |
@loan-laux I see that the tests are failing in this one. They shouldn't be but I suppose there is some change in a plugin that wasn't scrutinized properly causing this. |
Signed-off-by: Loan Laux <[email protected]>
…tgrow-auto-update-deps Signed-off-by: Loan Laux <[email protected]>
Signed-off-by: Loan Laux <[email protected]>
@Akarshit I've fixed the query tests, but the mutation tests keep failing. It's weird because they complain about the shop type being required as part of
So I'm a bit puzzled here. Don't have more time today to dive in but I'll come back to it soon. Let me know if you have any thoughts on what's happening here. I'm sure it's something simple I'm missing. |
I see that there's a step in the CI/CD pipeline that restores cache for |
I will get this fixed today. |
Looks like reactioncommerce/api-plugin-shops#30 should fix this. |
@Akarshit I re-ran the build and we're still getting the same error. Pretty sure there's a caching issue with CircleCI, on top of that problem you've fixed with the shop plugin. Is there any way to force it to reinstall the dependencies at every build? |
I think we need to remove the cache so that all the PRs are tested with the latest version of plugin. That change should be a part of this PR. |
13978f1
to
4bee890
Compare
Signed-off-by: Akarshit Wal <[email protected]>
4bee890
to
5a86480
Compare
🎉 This PR is included in version 3.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Signed-off-by: Loan Laux [email protected]
Resolves #6328
Impact: critical
Type: chore
Please see #6328 for initial discussion. This PR would allow auto minor updates on all
@reactioncommerce
production dependencies.