Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Xunit #52

Closed
wants to merge 58 commits into from
Closed

Port to Xunit #52

wants to merge 58 commits into from

Conversation

Arkatufus
Copy link

@Arkatufus Arkatufus commented Aug 21, 2020 •
edited
Loading

Related to #45

  • Port NUnit to Xunit
  • Update build framework target from net45 to net452 and netstandard2.0

@Aaronontheweb
Copy link

Did you get a chance to see this comment by @marcpiechura from last year?

#46 (comment)

@Arkatufus
Copy link
Author

Yes, that is possible to do in Xunit now

Arkatufus
Arkatufus commented Aug 21, 2020
View reviewed changes
src/tck/Reactive.Streams.TCK/Reactive.Streams.TCK.csproj
@@ -19,7 +19,9 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="NUnit" Version="3.7.1" />
<PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="Xunit.SkippableFact" Version="1.4.13" />
Copy link
Author

@Arkatufus Arkatufus Aug 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a small helper package that lets us skip Xunit tests programatically by throwing SkipException

Arkatufus
Arkatufus commented Aug 21, 2020
View reviewed changes
src/tck/Reactive.Streams.TCK/SubscriberBlackboxVerification.cs
@@ -314,7 +314,7 @@ public void Required_spec213_blackbox_onNext_mustThrowNullPointerExceptionWhenPa
{
var element = default(T);
if(element != null)
throw new IgnoreException("Can't verify behavior for value types");
throw new SkipException("Can't verify behavior for value types");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IgnoreException is replaced with SkipException

Arkatufus
Arkatufus commented Aug 21, 2020
View reviewed changes
src/tck/Reactive.Streams.TCK/Support/TckAssert.cs

namespace Reactive.Streams.TCK.Support
{
public static class TckAssert
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This static class is added to add Assert.Ignore (renamed to Skip) and Assert.Fail convenience static methods

Arkatufus and others added 16 commits August 22, 2020 00:37
@Arkatufus
Update build script to dotnet 3.1.105 LTS, add RunTestsDotNet build args
1c4a538
@Arkatufus
Merge branch 'master' into Update_to_Xunit
feb6247 
# Conflicts:
#	src/examples/Reactive.Streams.Example.Unicast.Tests/SyncSubscriberTest.cs
#	src/examples/Reactive.Streams.Example.Unicast.Tests/SyncSubscriberWhiteboxTest.cs
#	src/tck/Reactive.Streams.TCK.Tests/EmptyLazyPublisherTest.cs
#	src/tck/Reactive.Streams.TCK.Tests/IdentityProcessorVerificationTest.cs
#	src/tck/Reactive.Streams.TCK.Tests/RangePublisherTest.cs
#	src/tck/Reactive.Streams.TCK.Tests/SingleElementPublisherTest.cs
#	src/tck/Reactive.Streams.TCK.Tests/SubscriberBlackboxVerificationTest.cs
#	src/tck/Reactive.Streams.TCK.Tests/Support/TCKVerificationSupport.cs
#	src/tck/Reactive.Streams.TCK.Tests/SyncTriggeredDemandSubscriberTest.cs
#	src/tck/Reactive.Streams.TCK.Tests/SyncTriggeredDemandSubscriberWhiteboxTest.cs
@Arkatufus
Update framework targets and package versions
d9b05e3
@Arkatufus
Add xunit and Xunit.SkippableFact, replace [Test] with [SkippableFact]
3e2e02f 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Replace IgnoreException with SkipException
2c21b07 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Replace Assert.Ignore with TckAssert.Skip and Assert.Fail with …
4c56cd0 
…`TckAssert.Fail`

Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
replace Assert functions to the equivalent version in Xunit
9fa653e 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Add Assert.Fail and Assert.Ignore support
a6cb650 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Remove TextFixtureAttribute
5b50b7b 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Add ITestOutputHelper support
ab53717 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Fix OptionalActivePublisherTest, it was eating all exceptions
49fd87e 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Turn on netcoreapp3.1 testing
044a695 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Update build script to dotnet 3.1.105 LTS, add RunTestsDotNet build args
3a7436a 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@marcpiechura @Arkatufus
Added me to relicensing file
3a85e83 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@cconstantin @Arkatufus
Signed relicensing doc
de965e7 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@alexvaluyskiy @Arkatufus
Update Relicensing.txt
a5466f9 
Signed-off-by: Gregorius Soedharmo <[email protected]>
akarnokd and others added 29 commits May 18, 2021 00:11
@akarnokd @Arkatufus
Fix missing Cancel() in tests that don't consume the entire source (#32)
abd4803 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@akarnokd @Arkatufus
Update CopyrightWaivers.txt
c0225ec 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Skip §2.13 for value types (#34)
83730c7 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@marcpiechura @Arkatufus
fail if timeout is reached
d45bfa5 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
1.0.0 stable release (#28)
2b34b05 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
bump version
36ebf21 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@akarnokd @Arkatufus
Add the 'I' prefix to component names
5d687fc 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Megasware128 @Arkatufus
Update AsyncSubscriber.cs
d8964c0 
Subscritpion to Subscription

Signed-off-by: Gregorius Soedharmo <[email protected]>
@alexvaluyskiy @Arkatufus
Added xml documentation (#42)
dac6326 
* added xml documentation

* Updated NUnit runner

Signed-off-by: Gregorius Soedharmo <[email protected]>
@viktorklang @Arkatufus
Preparing for relicensing to MIT-0
a819a0e 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@akarnokd @Arkatufus
Update Relicensing.txt
785397d 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Add xunit and Xunit.SkippableFact, replace [Test] with [SkippableFact]
b68530b 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Replace IgnoreException with SkipException
fbf7f35 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Replace Assert.Ignore with TckAssert.Skip and Assert.Fail with …
39d5b7b 
…`TckAssert.Fail`

Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
replace Assert functions to the equivalent version in Xunit
463a68c 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Add Assert.Fail and Assert.Ignore support
380a841 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Remove TextFixtureAttribute
f43349c 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Add ITestOutputHelper support
7fd7136 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Fix OptionalActivePublisherTest, it was eating all exceptions
5ff3cba 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Turn on netcoreapp3.1 testing
bc73d6b 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Update build script to dotnet 3.1.105 LTS, add RunTestsDotNet build args
79008d1 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@marcpiechura @Arkatufus
Added me to relicensing file
07b7f26 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@cconstantin @Arkatufus
Signed relicensing doc
b9fb096 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@alexvaluyskiy @Arkatufus
Update Relicensing.txt
5ec79c5 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@viktorklang @Arkatufus
Port NUnit to XUnit, update target frameworks to netstandard2.0 and n…
2ff6255 
…et461, update nuget package versions

Author:    Gregorius Soedharmo <[email protected]>
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Update framework targets and package versions
68ef99a 
Signed-off-by: Gregorius Soedharmo <[email protected]>
@Arkatufus
Add xunit and Xunit.SkippableFact, replace [Test] with [SkippableFact]
b45555b
@Arkatufus
Merge branch 'Update_to_Xunit' of github.com:Arkatufus/reactive-strea…
9c99de1 
…ms-dotnet into Update_to_Xunit
@Arkatufus
Update target frameworks
16412fd
@Arkatufus Arkatufus closed this by deleting the head repository May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Arkatufus @Aaronontheweb @marcpiechura @cconstantin @alexvaluyskiy @viktorklang @akarnokd @Megasware128