Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating versions to 1.0.1-RC2 and clarifying changes in RELEASE-NOTE… #387

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Updating versions to 1.0.1-RC2 and clarifying changes in RELEASE-NOTE… #387

merged 1 commit into from
Jul 11, 2017

Conversation

viktorklang
Copy link
Contributor

…S.md

@viktorklang
Copy link
Contributor Author

@reactive-streams/contributors This PR updates the versions to 1.0.1-RC2 as well as describes the changes made from 1.0.1-RC1.

ktoso
ktoso reviewed Jul 11, 2017
View reviewed changes
RELEASE-NOTES.md Outdated

**1.0.1:** While the Subscription is not cancelled, Subscription.request(long n) MUST signal onError with a java.lang.IllegalArgumentException if the argument is <= 0. The cause message SHOULD explain that non-positive request signals are illegal.

**Comment: The MUST requirement to include a reference to the rule has been dropped in favor of a SHOULD requirement to clarify that non-positive requests are illegal.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To include a reference to the rule in the signaled exception?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better now (force pushed)

ktoso
ktoso approved these changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small cleanup I mentioned there.

Thanks a lot for taking care of the notes 👍

@viktorklang viktorklang merged commit d8dff1b into master Jul 11, 2017
@viktorklang viktorklang deleted the wip-1.0.1-RC2-√ branch July 11, 2017 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akarnokd akarnokd akarnokd approved these changes

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viktorklang @ktoso @akarnokd