Platform specific code #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this is really WASM specific it should rather reside in the platform head.
|
Right, that's why it should only be in the wasm head
…On Mon, Sep 23, 2019, 13:51 Glenn ***@***.***> wrote:
***@***.**** commented on this pull request.
The enlightenment isn't necessary for all platforms. Eg on rxui you would
just call RxApp.MainThreadScheduler
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5?email_source=notifications&email_token=AAUXFHDRLBQBBXRKOAJSZYTQLCUUDA5CNFSM4IZJSZWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFRUYQI#pullrequestreview-291720257>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUXFHGCOSDFCWLH6DN4L6DQLCUUDANCNFSM4IZJSZWA>
.
|
glennawatson
approved these changes
Sep 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is really WASM specific it should rather reside in the platform head.
What kind of change does this PR introduce?
Updated docs