Feature: Add MAUI support #691
Conversation
Fix name of initialize to reflect maui
Fix name of initialize to reflect maui
… into feature/maui
|
|
|
Hello, I cannot find a discussion regarding Sextant support for .net Maui. Is there any timeline for this? |
Apologies for not checking this more often... This particular contribution has been something I have been working on slowly on the side and is not something I've discussed with the maintainers. I have the package in a local version for net6.0 and am looking at what it would take to move it to net8.0 hopefully without breaking some of the other libraries that are in the repo. |
|
I am fairly certain that this release will be a breaking change release anyway, so better to put people on a new course that is forward compatible. |
…constructor for net8 and greater.
|
The tests are failing now, but at least the main build is good. Step by step it's getting there. Thank you for your efforts |
For the API Approved tests, what do I need to do to pass them, or because of the new frameworks they are expected to fail? |
|
Could you please run the tests on your machine to get the API checks updated |
When you run the tests two files are created, the verified file must match the discovered file, VS Code can be used to do the comparison |
When I run the tests locally I see the Approved files are generated as empty files but the tests still fail based on them being empty. Looking at the verified files they are also empty is this the expected output? |
|
One other strange observation is the net8.0 target framework name isnt pulling through so the approved version is named "ApiApprovalTests.Sextant..approved.txt" |
I can take a look and fix it if required, I have had to fix it in other repositories too so not a surprise this is failing |
|
I figured out the process for the updates to the txt files so they should be in the last commit now |
|
I will try to see what is happening at some point before my flight. |
|
if you can pull across the changes I made in #725 then this should fix the API issues, and mostly update the packages in the solution. I can't commit to your fork so I did this to try and help. |
Thank you for that help, I cherry-picked your commit from that PR over to this one so we should be able to run the tests again. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
==========================================
- Coverage 70.11% 62.13% -7.99%
==========================================
Files 32 27 -5
Lines 880 676 -204
Branches 0 82 +82
==========================================
- Hits 617 420 -197
+ Misses 263 226 -37
- Partials 0 30 +30 ☔ View full report in Codecov by Sentry. |
|
Ok, now I think that's everything fixed for build and samples... Tests worked and passed and with the samples updated, we should be good. I do still want to run a manual test on my end for macos to make sure that works properly if I can get my build host working properly for that. |
|
I will be going to the airport in about 5 hours, then I will be offline for about 14 hours. Glenn may be able to assist you with pushing the build runs, but I am not sure of his movements. |
Thank you both for your support in this effort. I am hopeful that there will be no more issues with the samples and that we can wrap this up soon. I tested the code on MacOS and it ran fine without any issues that I could visibly see with the sample app. |
|
Are there any more criteria you would like to see added before merging these changes? If no do you want me to merge the changes or is there a preview build you all would put out with this to field test it any further? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
Add support for Dotnet MAUI to Sextant by introducing a new library package that follows the existing prior art of the Xamarin Forms package. Updates for the CI/CD Pipeline were made using references from the main ReactiveUI pipelines.
What is the current behavior?
There is no support for Dotnet MAUI in Sextant nor is there a sample provided for using Sextant with Dotnet MAUI applications
What is the new behavior?
Ability to use Sextant for ViewModel-driven navigation with ReactiveUI in Dotnet MAUI applications.
What might this PR break?
The introduction of the new library package shouldn't break the existing Xamarin Forms or Avalonia packages. However, the changes to support Dotnet 6/7/8 may introduce breaking changes in packages outside the scope of this new functionality.
Please check if the PR fulfills these requirements
Other information: