Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(repeatWhen): Ensure teardown happens between repeat subscriptions #5625

Merged
merged 2 commits into from
Aug 5, 2020
Merged

fix(repeatWhen): Ensure teardown happens between repeat subscriptions #5625

merged 2 commits into from
Aug 5, 2020

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Aug 3, 2020

Resolves an issue where teardowns would wait until the resulting observable ended before being executed.

@benlesh
fix(repeatWhen): Ensure teardown happens between repeat subscriptions
5d8a7af 
Resolves an issue where teardowns would wait until the resulting observable ended before being executed.
@benlesh benlesh requested a review from cartant August 3, 2020 21:39
@benlesh benlesh mentioned this pull request Aug 3, 2020
Merged
cartant
cartant approved these changes Aug 4, 2020
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but probably want to rename subscribeNext - as in the repeat PR.

src/internal/operators/repeatWhen.ts Outdated Show resolved Hide resolved
@benlesh benlesh merged commit 98356f4 into ReactiveX:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benlesh @cartant