refactor(timeout): Getting rid of _unsubscribeAndRecycle #5626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an effort to simplify the code base, along with the other work to retry, retryWhen, repeat, and repeatWhen, this should help us get rid of `_unsubscribeAndRecycle` and move us toward simplifying Subscriber in the long run. There are obviously some memory trade offs using functions on POJOs over on prototypes, but given other recent memory improvements, I think that is probably not a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to simplify the code base, along with the other work to retry, retryWhen, repeat, and repeatWhen, this should help us get rid of
_unsubscribeAndRecycleand move us toward simplifying Subscriber in the long run. There are obviously some memory trade offs using functions on POJOs over on prototypes, but given other recent memory improvements, I think that is probably not a big deal.All part of a cohesive plan that you might see coming together with #5625 #5623 #5621 #5620 et al.