Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

Add notes for December, 8 #39

Merged
merged 1 commit into from
Dec 9, 2016
Merged

Add notes for December, 8 #39

merged 1 commit into from
Dec 9, 2016

Conversation

gaearon
Copy link
Member

@gaearon gaearon commented Dec 9, 2016

Feel free to discuss in this PR!

@gaearon gaearon merged commit 266a5b1 into master Dec 9, 2016
@gaearon gaearon deleted the gaearon-patch-2 branch December 9, 2016 17:14
In addition to the above we may also focus on these important areas as stretch goals:

* Design new functional component API with declarative data subscriptions
* Publicly deprecate `createClass`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ DANGER ZONE⚠️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll go to a package so people who rely on it can use it separately.

@aickin
Copy link

aickin commented Dec 9, 2016

As always, thanks for posting these. Two questions:

  1. I'm curious about the mentions of SSR, which make it sound like there may be some difficulties with Fiber + SSR. Can you expand on this? From the goals section, it seems that SSR will remain a supported feature in Fiber, which is great, but I would love to learn more about what the conflict is.
  2. It's really cool that Brian was able to write another renderer against Fiber's renderer API. Is this API documented in any form? I'd love to look at it and think about it if possible, though I totally understand if it isn't documented yet.

@iamdustan
Copy link

Re: 2. https://github.com/facebook/react/blob/master/src/renderers/shared/fiber/ReactFiberReconciler.js#L43-L71

@sophiebits
Copy link
Member

  1. Currently, Fiber isn't set up to generate HTML or to revive it. There isn't any conceptual incompatibility with doing either, but it's something we need to figure out before an open source release because many people use SSR heavily. One option would be to use a separate server-side renderer like you were working on.

  2. No documentation for renderers yet but you can read through what Brian wrote here: https://github.com/reactjs/react-art/blob/c6f7a5c2972c09682911eac6752c946a60315415/src/ReactARTFiber.js#L389-L504. I can't promise that we'll find time to write docs anytime soon but I'm happy to clarify what any method does if it's confusing.

@aickin
Copy link

aickin commented Dec 9, 2016

Thanks so much for the (absurdly!) quick responses and pointers to more information.

Also thanks @spicyj for the offer to clarify what the methods do! Sorry to be so nuts and bolts, but what's the best forum for that?

@sophiebits
Copy link
Member

There's probably a better forum, but want to just Messenger me? https://m.me/spicyj

@iamdustan
Copy link

I started #react-internals on Reactiflux for this kinda purpose if either of you want to join me and a few others that hang out in there. https://discordapp.com/channels/102860784329052160/148818842779385856

Hopefully having a few additional folks may see the conversation would help to disseminate the knowledge.

@gaearon
Copy link
Member Author

gaearon commented Dec 9, 2016

@iamdustan I’ll be there! 👍

@sophiebits
Copy link
Member

sophiebits commented Dec 9, 2016

If I'm being honest, I probably won't actually be responsive on Discord. I created an open Messenger room though: https://m.me/g/Abas8IcWxIvjVxHN. Hope that's not too inconvenient for interested parties.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants