Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate SyntheticEvent #29

Merged
merged 38 commits into from
Feb 2, 2019
Merged

Translate SyntheticEvent #29

merged 38 commits into from
Feb 2, 2019

Conversation

Cavallando
Copy link
Contributor

Translation of SyntheticEvent section. Had a lot of help from my friend who speaks Spanish as his first language, please let me know anything that you think might need some help!

Referencing Issue: #26

@Cavallando Cavallando mentioned this pull request Feb 1, 2019
Closed
@Cavallando
Copy link
Contributor Author

Github is not allowing me to assign, I believe due to permissions (unless I am missing something dumb). Want to make sure I am following the contributing guidelines, hopefully this comment is acceptable form of assigning! @dmoralesm, @carburo and @alejandronanez

@alejandronanez
Copy link
Member

Hey @michaelcavallaro03, thanls for this PR! Welcome 👏

You're not dumb (please don't say that), you just don't have enough permissions. I'll set that up for you, thanks again!

hugmanrique
hugmanrique suggested changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@hugmanrique hugmanrique left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some incorrect translations and typos, but this PR looks pretty good!

Thanks for your work 😊

content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
EzequielMonforte and others added 12 commits February 1, 2019 11:40
@EzequielMonforte @Cavallando
Update content/docs/reference-events.md
0dd1e42 
Co-Authored-By: michaelcavallaro03 <[email protected]>
@hugmanrique @Cavallando
Update content/docs/reference-events.md
70c5655 
Co-Authored-By: michaelcavallaro03 <[email protected]>
@hugmanrique @Cavallando
Update content/docs/reference-events.md
c371fb2 
Co-Authored-By: michaelcavallaro03 <[email protected]>
@hugmanrique @Cavallando
Update content/docs/reference-events.md
7967f3d 
Co-Authored-By: michaelcavallaro03 <[email protected]>
@hugmanrique @Cavallando
Update content/docs/reference-events.md
4a25ae8 
Co-Authored-By: michaelcavallaro03 <[email protected]>
@hugmanrique @Cavallando
Update content/docs/reference-events.md
d570bc0 
Co-Authored-By: michaelcavallaro03 <[email protected]>
@hugmanrique @Cavallando
Update content/docs/reference-events.md
be63fa2 
Co-Authored-By: michaelcavallaro03 <[email protected]>
@hugmanrique @Cavallando
Update content/docs/reference-events.md
3638bef 
Co-Authored-By: michaelcavallaro03 <[email protected]>
@hugmanrique @Cavallando
Update content/docs/reference-events.md
567ef70 
Co-Authored-By: michaelcavallaro03 <[email protected]>
@hugmanrique @Cavallando
Update content/docs/reference-events.md
8cb0dab 
Co-Authored-By: michaelcavallaro03 <[email protected]>
@hugmanrique @Cavallando
Update content/docs/reference-events.md
30da3dd 
Co-Authored-By: michaelcavallaro03 <[email protected]>
@hugmanrique @Cavallando
Update content/docs/reference-events.md
5ce83b7 
Co-Authored-By: michaelcavallaro03 <[email protected]>
@hugmanrique
Copy link
Contributor

hugmanrique commented Feb 1, 2019 •
edited
Loading

Fixed the event name suggestions, thanks gariasf 😜

hugmanrique and others added 7 commits February 1, 2019 12:56
hugmanrique and others added 8 commits February 1, 2019 13:12
@Cavallando
Copy link
Contributor Author

Thank you all for your comments and your work reviewing/translating overall! I added the changes that you all discussed/requested. Please let me know if there is anything else necessary to change!

alejandronanez
alejandronanez requested changes Feb 1, 2019
View reviewed changes
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @michaelcavallaro03,

Thanks for your PR, this is getting close to what we want!

I'm requesting changes because of this https://github.com/reactjs/es.reactjs.org/pull/29/files#diff-551c454828b77e72a3859b9731768e7eR250

Let us know if you need help with anything else!

content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
@Cavallando
Copy link
Contributor Author

Committed your suggestions @alejandronanez as well as removed that silly usage of React as a verb and kept polyfill as is!

alejandronanez
alejandronanez approved these changes Feb 2, 2019
View reviewed changes
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @michaelcavallaro03, thanks for your contribution!

Merging!

@alejandronanez alejandronanez merged commit 465759d into reactjs:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzequielMonforte EzequielMonforte EzequielMonforte left review comments

@hugmanrique hugmanrique hugmanrique requested changes

@gariasf gariasf gariasf left review comments

@carburo carburo carburo left review comments

@alejandronanez alejandronanez alejandronanez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Cavallando @alejandronanez @hugmanrique @carburo @gariasf @EzequielMonforte