Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate react-dom/client #666

Merged
merged 2 commits into from
May 3, 2023
Merged

Translate react-dom/client #666

merged 2 commits into from
May 3, 2023

Conversation

merojosa
Copy link
Contributor

  • Revisé en otras página que API es usado en femenino, por lo que me refiero a estos APIs como las.
  • Según entiendo, la palabra polyfills no existe en español. Revisé en el glosario de MDN qué hicieron, y ellos la dejaron en inglés.

image

Copy link
Collaborator

@mateoguzmana mateoguzmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se ve muy bien, te dejé dos comentarios pequeños.

src/content/reference/react-dom/client/index.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/client/index.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 1, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.67 KB (🟢 -23 B) 170.3 KB
/500 76.67 KB (🟢 -23 B) 170.29 KB
/[[...markdownPath]] 78.14 KB (🟢 -23 B) 171.76 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@mateoguzmana mateoguzmana self-requested a review May 2, 2023 04:52
@carburo carburo merged commit 9990527 into reactjs:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants