-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with react.dev @ 0f2284dd #283
Open
react-translations-bot
wants to merge
390
commits into
main
Choose a base branch
from
sync-0f2284dd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Edits for new "use client" content * Apply suggestions from code review Co-authored-by: Luna <[email protected]> --------- Co-authored-by: Luna <[email protected]>
Summary of changes: "Server Action", like "Effect", is a React-specific notion that would be benefited from captailization to be distinguished from its genertic meaning. It seems like [Next doc](https://nextjs.org/docs/app/api-reference/functions/server-actions) has also adopted such connventions and we should probably do the same. Co-authored-by: xuan.huang <[email protected]>
Summary of changes: following <reactjs/react.dev#6417> Co-authored-by: xuan.huang <[email protected]>
Summary of changes: See <reactjs/react.dev#6417> Co-authored-by: xuan.huang <[email protected]>
Co-authored-by: Luna Wei <[email protected]>
Summary of changes: See <reactjs/react.dev#6417>. There is one exception though. The error message “Rendered fewer hooks than expected” from React is indeed "hooks" so I kept as-is. Shall we change the error message from React? Co-authored-by: xuan.huang <[email protected]>
Summary of changes: See <reactjs/react.dev#6417> Co-authored-by: xuan.huang <[email protected]>
Summary of changes: See <reactjs/react.dev#6417> Co-authored-by: xuan.huang <[email protected]>
…(#6445) * Fix: component not returned * Fix: missing function statement
Summary of changes: There is one "TypeScript strict mode" that is kept unchanged. Co-authored-by: xuan.huang <[email protected]>
Co-authored-by: Sebastian Silbermann <[email protected]>
this way "cannot be marked" is all the same style and you don't skim the link text and gloss over the "cannot be"
* fix(sandpack-template): use custom react sandpack template * refactor: Remove console.log statement Remove console.log(filePath); from createFileMap.ts * style: Update file paths in Sandpack components Update file paths in Sandpack components to use root folder and variables
* feat: add react india 2024 * update: move react india 2024 in date order * update: move conferences to past section * refactor: sort past conferences
…6496) * specify which sandbox files go in src directory * fix some stragglers
Added missing comma to the codesample.
Expo now has its own instructions for enabling the compiler.
Co-authored-by: Sebastian Silbermann <[email protected]>
…(#7108) * Emphasize the second problem acapit with chain of effects example * Replace 'One' with 'First' to keep problems counting consistent
PR to add Radv 2024 conference
Co-authored-by: Tom Eastman <[email protected]>
* Update conferences.md, add conference * Update conferences.md --------- Co-authored-by: Eli White <[email protected]>
…… (#6691) * Changed the documentation of the subscribe argument to a more accurate one. * Update useSyncExternalStore.md --------- Co-authored-by: Sophie Alpert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from react.dev at 0f2284d
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.