Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate dom-elements #12

Merged
merged 12 commits into from
Feb 3, 2019
Merged

Translate dom-elements #12

merged 12 commits into from
Feb 3, 2019

Conversation

kn3ny
Copy link
Contributor

@kn3ny kn3ny commented Feb 1, 2019

Related Issue: #4
Translation of https://reactjs.org/docs/dom-elements.html


  • crowdinの翻訳を適用
  • 未翻訳部分を翻訳
  • crowdinで既に翻訳されていた部分で、少し違和感がある部分の修正

@smikitky
Copy link
Member

smikitky commented Feb 2, 2019

準備ができたところで呼んでくださいませ

@kn3ny kn3ny changed the title WIP: Translate dom-elements Translate dom-elements Feb 2, 2019
@kn3ny
Copy link
Contributor Author

kn3ny commented Feb 2, 2019

@smikitky ありがとうございます!翻訳終わりましたので、レビューをお願いします 🙇

@smikitky smikitky self-requested a review February 2, 2019 09:09
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

幾つか対応をお願いします。

content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
@kn3ny
Copy link
Contributor Author

kn3ny commented Feb 2, 2019

@smikitky レビュー&パッチありがとうございました。内容を確認して修正しました 👍

@smikitky
Copy link
Member

smikitky commented Feb 2, 2019

非常にクオリティの高い翻訳で助かりました!
次回から "Add Suggestion to Batch" の方も使ってみてください

@kn3ny
Copy link
Contributor Author

kn3ny commented Feb 2, 2019

@smikitky レビューお疲れ様です。次回以降はBatch使いますね 🙇

@tesseralis tesseralis mentioned this pull request Feb 2, 2019
90 tasks
@smikitky smikitky merged commit ac69e0e into reactjs:master Feb 3, 2019
@kn3ny kn3ny deleted the dom-elements-ja branch February 4, 2019 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants