Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate how-to-contribute #123

Merged
merged 14 commits into from
Feb 27, 2019
Merged

Translate how-to-contribute #123

merged 14 commits into from
Feb 27, 2019

Conversation

oimo23
Copy link
Contributor

@oimo23 oimo23 commented Feb 15, 2019

No description provided.

@oimo23
Copy link
Contributor Author

oimo23 commented Feb 15, 2019

related issue: #4
Translation: How to Contribute

すみません、誤まって description が空欄になっていました。
レビューをよろしくお願いいたします🙇

potato4d
potato4d requested changes Feb 16, 2019
View reviewed changes
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oimo23
レビューの前段階として、 Lint エラーの修正をお願いいたします。
yarn でパッケージをインストール後、 yarn lint:text で確認できます！

@oimo23
Copy link
Contributor Author

oimo23 commented Feb 19, 2019

@potato4d
失礼しました、Lintエラー修正をしましたので再度よろしくお願いします！

potato4d
potato4d requested changes Feb 23, 2019
View reviewed changes
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ざっと見ました！
ほとんど機械的な変更となりますが、対応いただけると助かります！

content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Feb 25, 2019 •
edited
Loading

Deploy preview for ja-reactjs ready!

Built with commit 8e1862e

https://deploy-preview-123--ja-reactjs.netlify.com

@oimo23
Copy link
Contributor Author

oimo23 commented Feb 25, 2019

@potato4d
レビューありがとうございます。
suggest を取り込んで修正させて頂きました！

smikitky
smikitky requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@smikitky smikitky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなりましたがレビューしましたので確認をお願いします。
あと「出来る」が複数残っているので「できる」に置換していただいてよいでしょうか。

content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
@potato4d
Copy link
Member

Mixed content でエラーが出ているけれど、これは原文もそうなので仕方なさそう？

@tesseralis tesseralis mentioned this pull request Feb 25, 2019
Closed
90 tasks
@oimo23
Copy link
Contributor Author

oimo23 commented Feb 25, 2019

@smikitky
丁寧なレビューありがとうございます。
修正と、suggest の取り込みをさせて頂きました。

@potato4d
この規模のOSS貢献にはまだ不慣れで、色々と不手際があって申し訳ないです！
現在は直ったと思います、よろしくお願いします。

smikitky
smikitky requested changes Feb 26, 2019
View reviewed changes
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、幾つか対応されていなかったものがあります。前のレビューは忘れてよいので改めてこちらを確認いただけますでしょうか。

「あなた」が文中にかなり多用されていましたが、他の翻訳との整合性もあるので必要でない部分については省くサジェスチョンをさせていただきました。（逆に1か所「あなた」に対応する語がないと意味が通らなくなる部分があるので追加しました。）

content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
@smikitky
Copy link
Member

ありがとうございました！

@oimo23
Copy link
Contributor Author

oimo23 commented Feb 26, 2019

@smikitky
改めて今回の suggest を取り込ませて頂きました。
こちらこそありがとうございました！

potato4d
potato4d approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oimo23
いえ、翻訳いただいてとても助かりました！ありがとうございます！

LGTM

@potato4d potato4d merged commit 64ddd16 into reactjs:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smikitky smikitky smikitky approved these changes

@potato4d potato4d potato4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oimo23 @potato4d @smikitky