Translate API Reference of React.Component #127
Merged
+175
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightnet328
changed the title
90 tasks
|
Deploy preview for ja-reactjs ready! Built with commit 5c79337 |
koba04
requested changes
Feb 20, 2019
There was a problem hiding this comment.
@lightnet328
翻訳お疲れ様です！
長いページなので、コメント多くなってしまいましたがご確認お願いします！ 🙇
細かいものばかりです。
|
|
||
| Normally you should try to avoid all uses of `forceUpdate()` and only read from `this.props` and `this.state` in `render()`. | ||
| 通常は `forceUpdate()` の使用をすべて避け、`render()` の `this.props` と `this.state` からのみ読み取るようにしてください。 |
There was a problem hiding this comment.
言い回しを調整しました [IMO]
Suggested change
| 通常は `forceUpdate()` の使用をすべて避け、`render()` の `this.props` と `this.state` からのみ読み取るようにしてください。 | |
| 通常は全ての `forceUpdate()` の使用を避け、`render()` の `this.props` と `this.state` からのみ読み取るようにしてください。 |
There was a problem hiding this comment.
こちら、ご提案いただいた内容のほうが良いと思うので取り込ませていただきました。
また、「通常は forceUpdate() を使用せずに、」ではどうでしょうか？意訳しすぎでしょうか。
There was a problem hiding this comment.
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
|
@koba04 レビューしていただき、ありがとうございます！ |
koba04
requested changes
Feb 21, 2019
There was a problem hiding this comment.
@lightnet328 表示がおかしくなっている部分があったのでコメントしましたのでそこだけ確認お願いします 🙏
1つは自分がsuggestionした部分でした。失礼しました 🙇
lightnet328
force-pushed
the
translate/api-reference-react-component
branch
from
2c70307
to
80d8236
Compare
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
Co-Authored-By: lightnet328 <[email protected]>
lightnet328
force-pushed
the
translate/api-reference-react-component
branch
from
7763181
to
bb7b035
Compare
|
Markdownが崩れている部分について修正しました🙇 |
|
@lightnet328 対応ありがとうございました！ |
koba04
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of #4.
Translate: React.Component – React