Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate testing #241

Merged
merged 13 commits into from
Sep 4, 2019
Merged

Translate testing #241

merged 13 commits into from
Sep 4, 2019

Conversation

taneba
Copy link
Contributor

@taneba taneba commented Aug 30, 2019

This PR is part of #4
1/3 of testing docs

@netlify
Copy link

netlify bot commented Aug 30, 2019

Deploy preview for ja-reactjs ready!

Built with commit d82508c

https://deploy-preview-241--ja-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Aug 30, 2019

Deploy preview for ja-reactjs ready!

Built with commit 1e547d1

https://deploy-preview-241--ja-reactjs.netlify.com

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつかコメントしました〜。

content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Show resolved Hide resolved
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ありがとうございました!

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taneba
翻訳ありがとうございます!!
細かい言い回しの修正ばかりですがコメントしたので確認お願いします 🙇

content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
taneba and others added 8 commits September 4, 2019 11:42
Co-Authored-By: Toru Kobayashi <[email protected]>
Co-Authored-By: Toru Kobayashi <[email protected]>
Co-Authored-By: Toru Kobayashi <[email protected]>
Co-Authored-By: Toru Kobayashi <[email protected]>
Co-Authored-By: Toru Kobayashi <[email protected]>
Co-Authored-By: Toru Kobayashi <[email protected]>
Co-Authored-By: Toru Kobayashi <[email protected]>
Co-Authored-By: Toru Kobayashi <[email protected]>
@taneba
Copy link
Contributor Author

taneba commented Sep 4, 2019

@koba04
レビューありがとうございました!
2点コメント返しましたのでご確認お願いします 🙇

taneba and others added 2 commits September 4, 2019 13:54
Co-Authored-By: Toru Kobayashi <[email protected]>
Co-Authored-By: Toru Kobayashi <[email protected]>
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taneba
すみません、suggestionsの内容が古いようでした。
@taneba さんの翻訳に近い形に戻したものが本来提案したかったものなので改めて確認お願いします。
お手数お掛けしてすみません 🙇

こちらでApproveにしたいと思います。

content/docs/testing.md Outdated Show resolved Hide resolved
Co-Authored-By: Toru Kobayashi <[email protected]>
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 対応ありがとうございました!!

@koba04 koba04 merged commit 6c9b55c into reactjs:master Sep 4, 2019
@tesseralis tesseralis mentioned this pull request Sep 4, 2019
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants