Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate hooks-custom #65

Merged
merged 3 commits into from
Feb 14, 2019
Merged

Translate hooks-custom #65

merged 3 commits into from
Feb 14, 2019

Conversation

smikitky
Copy link
Member

@smikitky smikitky commented Feb 5, 2019

6/8 of Hooks articles

@tesseralis tesseralis mentioned this pull request Feb 6, 2019
90 tasks
@smikitky
Copy link
Member Author

smikitky commented Feb 7, 2019

#91 でフックに関わる差分がマージされます。翻訳を修正するまでマージはお待ちください。

@smikitky
Copy link
Member Author

smikitky commented Feb 7, 2019

修正しました

@smikitky
Copy link
Member Author

smikitky commented Feb 9, 2019

直ってないみたい…

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflictしてる以外は問題ないと思うのでApproveしておきます。

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうですー。
もしコンフリクト解消、マージ後に Lint が落ちてたら修正してもらって、そこからセルフマージで大丈夫です!

@smikitky smikitky merged commit ed05a3b into master Feb 14, 2019
@smikitky smikitky deleted the tr/hooks-custom branch February 14, 2019 09:19
@smikitky
Copy link
Member Author

ありがとうございました!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants