Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate accessibility #99

Merged
merged 8 commits into from
Feb 15, 2019
Merged

translate accessibility #99

merged 8 commits into from
Feb 15, 2019

Conversation

sasurau4
Copy link
Contributor

@sasurau4 sasurau4 commented Feb 8, 2019 •
edited
Loading

This PR part of #4

リンクタイトルは、固有名詞以外は基本的に訳す方向にしてみました。ちょっと方針をどうするか迷ったので意見あれば、コメントください 🙏

@sasurau4 sasurau4 changed the title translate accessibility doc [WIP] translate accessibility doc Feb 8, 2019
@sasurau4 sasurau4 changed the title [WIP] translate accessibility doc translate accessibility doc Feb 8, 2019
@sasurau4 sasurau4 changed the title translate accessibility doc translate accessibility Feb 8, 2019
@smikitky smikitky self-requested a review February 9, 2019 15:37
@smikitky smikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 9, 2019
smikitky
smikitky requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よろしくおねがいします。

リンクタイトルの訳の件ですが、個人的には、ジャンプ先の記事の英語のタイトルがそのままリンクテキストになっているような部分は、翻訳せずに残しておいたほうがいい気がします。ジャンプ先に英語しかないということをあらかじめ暗示しておいたほうが、クリックした後にがっかりしないで済むと思いますので :)

content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
@smikitky smikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 9, 2019
@tesseralis tesseralis mentioned this pull request Feb 9, 2019
Closed
90 tasks
potato4d
potato4d requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sasurau4
コントラストの部分だけ要修正です。お願いいたします！

content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
@sasurau4
Copy link
Contributor Author

sasurau4 commented Feb 10, 2019 •
edited
Loading

@smikitky
レビューありがとうございます 🙏
修正しました。
リンクした先が英語だったときの残念感はすごく感じるので、リンクタイトルがリンク先のタイトルとほぼ同じものは英語、補足や説明が入っている場合は日本語にしてみました。
確認お願いします。

@potato4d
レビューありがとうございます 🙏 色弱の件だけ、少し調べて変更したので確認お願いします。

potato4d
potato4d approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！

@potato4d
Copy link
Member

@sasurau4
追加の Lint ルールでコケてしまったので対応だけいただけますか 🙇

@sasurau4
Copy link
Contributor Author

@potato4d lint fixしました 🙏

@potato4d potato4d merged commit 7d6dc62 into reactjs:master Feb 15, 2019
@sasurau4 sasurau4 deleted the translate/accessibility branch February 15, 2019 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usagi-f usagi-f usagi-f left review comments

@smikitky smikitky smikitky approved these changes

@potato4d potato4d potato4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sasurau4 @potato4d @smikitky @usagi-f