Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate code-splitting.md #55

Merged
merged 15 commits into from
Mar 26, 2019
Merged

Conversation

liante0904
Copy link
Contributor

@liante0904 liante0904 commented Feb 28, 2019

Progress

@netlify
Copy link

netlify bot commented Feb 28, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit 12dbe01

https://deploy-preview-55--ko-reactjs-org.netlify.com

@taehwanno
Copy link
Member

master에 모든 링크가 http -> https로 변경되어서 직접 충돌 해결했습니다.

content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ENvironmentSet ENvironmentSet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 제 몸을 가눌 수 있을 때 까지 리뷰를 해 보았습니다.
이 이후에도 몇몇 문제점이 보이는데, 잠시 자고 와서 다른 분들이 리뷰해주시지 않으셨다면 제가 달아드리겠습니다.

content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
@taehwanno
Copy link
Member

@liante0904 리뷰 사항 몇가지가 누락된 것 같아요. 코멘트가 많아서 아래처럼 "Load more"을 눌러야 추가적으로 더 보실 수 있을거에요. 확인 한번 부탁드려요.

image

content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

띄어쓰기 오류가 있어 바로잡습니다.

content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
gnujoow
gnujoow previously requested changes Mar 6, 2019
content/docs/code-splitting.md Outdated Show resolved Hide resolved
@taehwanno
Copy link
Member

변경된 링크에 대해 직접 충돌을 해결했습니다.

taehwanno
taehwanno previously approved these changes Mar 6, 2019
re-rendering the entire page at once so your users are unlikely to be
interacting with other elements on the page at the same time.
이를 시작하기 좋은 장소는 경로(routes)입니다. 웹 페이지를 불러오는 시간은 페이지 전환에 어느 정도 발생하며 대부분 페이지를 한번에 렌더링하기 때문에
사용자가 페이지를 렌더링하는 동안 다른 요소와 상호작용하지 않습니다.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

route는 번역하지 않고 라우트로 사용 하는게 어떨까요? 경로라고 번역되니 의미가 잘 전달되지 않는 것 같아서요.
@taehwanno

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simsim0709 express.js 번역도 라우팅으로 되어 있는 걸 보니 무리는 없을 것 같네요. 고민하다가 경로 리뷰 드렸는데 라우트로 변경에 동의합니다 :)

@liante0904 변경 부탁드릴게요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taehwanno @simsim0709 경로(routes)에서 라우트 로 변경하면 될까요?
하단 Route-based code splitting 항목에서 how to setup route-based code splitting경로 기반으로 번역하였는데 이 경우도 라우트 기반으로 변경하면 될지 확인하고 수정 commit 하려고 합니다.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liante0904 네 맞습니다 :) 🚀

taehwanno
taehwanno previously approved these changes Mar 17, 2019
@simsim0709 simsim0709 dismissed gnujoow’s stale review March 26, 2019 03:55

추가 될 -> 추가될로 제가 직접 수정 했습니다.

@simsim0709
Copy link
Collaborator

@taehwanno 님이 이미 리뷰 accept 한 상태였고, @gnujoow 님이 요청한 수정사항 제가 직접 수정해서 pr 머지 하겠습니다.

@simsim0709 simsim0709 merged commit 68563bd into reactjs:master Mar 26, 2019
@simsim0709
Copy link
Collaborator

@liante0904 님 수고하셨습니다! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants