Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks / Rules of Hooks #11

Merged
merged 43 commits into from
Feb 14, 2019
Merged

Hooks / Rules of Hooks #11

merged 43 commits into from
Feb 14, 2019

Conversation

thadeu
Copy link
Contributor

@thadeu thadeu commented Feb 8, 2019

#1

content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
WendellAdriel and others added 27 commits February 8, 2019 14:56
@WendellAdriel WendellAdriel added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Em uma review feita no PR, questionaram sobre os títulos semelhantes a documentação original deixado as primeiras letras maiúsculas de cada palavra.

content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thadeu só capitaliza os títulos assim como estão no inglês.
Ex.: Rules of Hooks => Regras dos Hooks

Alterando isso, me sinalize como @glaucia86, que estarei aprovando a sua contribuição!
(não esqueça de alterar o label e me sinalizar).

@glaucia86 glaucia86 added needs author response Changes requested needing author's input and removed feedback addressed needs +1 Needs another approval before merging labels Feb 11, 2019
@glaucia86
Copy link
Member

@thadeu @jhonmike vou fazer o seguinte. Como é dia de semana e muita gente está trabalhando e não terão tempo hábil para fazer essa mudança, estarei aprovando esse PR. Depois q terminar de fazer as análises de hoje, estarei fazendo um fork e acertando esses títulos.

cc: @cezaraugusto e @WendellAdriel @eduardomoroni @fjoshuajr só para sinalizar vocês q provavelmente daqui a pouco criarei uma branch para fazer esses acertos. Assim que enviar, sinalizo vocês para aprovarem.

@WendellAdriel
Copy link
Member

Ok @glaucia86, combinado!!! 😉

@thadeu thadeu dismissed stale reviews from WendellAdriel via 42c7ae5 February 11, 2019 20:44
@thadeu
Copy link
Contributor Author

thadeu commented Feb 11, 2019

@thadeu só capitaliza os títulos assim como estão no inglês.
Ex.: Rules of Hooks => Regras dos Hooks

Alterando isso, me sinalize como @glaucia86, que estarei aprovando a sua contribuição!
(não esqueça de alterar o label e me sinalizar).

@glaucia86 Títulos corrigidos, Obrigado!

cc: @WendellAdriel @jhonmike @cezaraugusto pode alterar o label, por favor?

Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thadeu
LGTM 👍

Muito obrigada pela sua contribuição!

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed feedback addressed 💪 long page - more than 100 lines Long page labels Feb 14, 2019
@glaucia86
Copy link
Member

cc: @WendellAdriel @eduardomoroni só aprovar. Mais do que revisto essa PR rsrsrsrs

Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 14, 2019
@fjoshuajr fjoshuajr merged commit bb0c149 into reactjs:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants