Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting translation as discussed #35

Merged
merged 2 commits into from
Feb 9, 2019

Conversation

halian-vilela
Copy link
Collaborator

Adjusting as stated in #10 (comment)

@cezaraugusto cezaraugusto added the follow-up Changes applied in a previously translated file label Feb 9, 2019
cezaraugusto
cezaraugusto previously approved these changes Feb 9, 2019
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@cezaraugusto cezaraugusto added the needs +1 Needs another approval before merging label Feb 9, 2019
@fjoshuajr
Copy link
Collaborator

Looking good!

I'll wait for a consensus among the members about whether we should translate internal links or not.

@fjoshuajr fjoshuajr added the needs resolution Something not defined that needs maintainers input label Feb 9, 2019
@cezaraugusto
Copy link
Member

@fjoshuajr re link translation I created #42. I guess we're good to go with this one

@cezaraugusto cezaraugusto removed the needs resolution Something not defined that needs maintainers input label Feb 9, 2019
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@cezaraugusto cezaraugusto merged commit 97aef45 into reactjs:master Feb 9, 2019
@cezaraugusto cezaraugusto added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging 🌐 translated Translation is completed for this page labels Feb 9, 2019
@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed 🌐 translated Translation is completed for this page labels Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow-up Changes applied in a previously translated file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants