Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for forwardRef<generics> #923

Merged
merged 8 commits into from
Aug 31, 2024

Conversation

rvetere
Copy link
Contributor

@rvetere rvetere commented May 27, 2024

Add support for generic types on forwardRef calls:

export const FullWidthButton = forwardRef<HTMLButtonElement, IButtonProps>() => {}

Fixes #927

Copy link

changeset-bot bot commented May 27, 2024

🦋 Changeset detected

Latest commit: a763a90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
react-docgen Minor
@react-docgen/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 27, 2024

Deploy Preview for react-docgen ready!

Name Link
🔨 Latest commit 45b9a89
🔍 Latest deploy log https://app.netlify.com/sites/react-docgen/deploys/6654c5a0be482a00085be717
😎 Deploy Preview https://deploy-preview-923--react-docgen.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for react-docgen canceled.

Name Link
🔨 Latest commit a763a90
🔍 Latest deploy log https://app.netlify.com/sites/react-docgen/deploys/66d2fe516ab68800087b204d

@rvetere rvetere changed the title Feature/forward ref generics Add support for forwardRef<generics> May 28, 2024
@danez danez enabled auto-merge (squash) August 31, 2024 11:29
@danez danez merged commit 3033ca0 into reactjs:main Aug 31, 2024
16 checks passed
@danez
Copy link
Collaborator

danez commented Aug 31, 2024

Thank you for all the work! I will go through all of it.

Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No support for forwardRef calls typed with generics
2 participants