Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-dom should probably be a peerDependency #219

Closed
boucher opened this issue Sep 6, 2016 · 0 comments
Closed

react-dom should probably be a peerDependency #219

boucher opened this issue Sep 6, 2016 · 0 comments

Comments

@boucher
Copy link

boucher commented Sep 6, 2016

Summary:

React is being declared as a peerDependency, but react-dom is not (but both are dev dependencies).

Steps to reproduce:

  1. Visit https://tonicdev.com/npm/react-modal and try to run the example

Expected behavior:

The package should be required. It will fail because of the missing peer dependency. If you add a require("react-dom") before hand, it will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant