Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[added] The ability to decide whether the modal should be closed when clicking the overlay area #128

Merged
merged 1 commit into from
Mar 26, 2016

Conversation

dorsha
Copy link
Contributor

@dorsha dorsha commented Feb 19, 2016

This is an important ability since in some cases we don't want the modal to be closed when users are clicking outside.

@dorsha
Copy link
Contributor Author

dorsha commented Feb 20, 2016

Fixes: #129

@dorsha dorsha changed the title Added the ability to decide whether the modal should be closed when clicking the overlay area [added] The ability to decide whether the modal should be closed when clicking the overlay area Feb 20, 2016
@aviadlich
Copy link

+1

@claydiffrient
Copy link
Contributor

@dorsha Could you add a spec testing this feature? I generally prefer tests to be in place for code changes, especially for new functionality.

@dorsha
Copy link
Contributor Author

dorsha commented Mar 24, 2016

@claydiffrient I added tests for the feature, please review.

@claydiffrient
Copy link
Contributor

@dorsha would you mind squashing the three commits down to one? That would help keep the git history (and changelog) a bit more clean, especially since all three relate to the one functional change.

@dorsha
Copy link
Contributor Author

dorsha commented Mar 25, 2016

@claydiffrient - done

@claydiffrient
Copy link
Contributor

@dorsha It now appears that you have 5 commits in the PR. A decent guide to squashing the commits in a pull request is http://eli.thegreenplace.net/2014/02/19/squashing-github-pull-requests-into-a-single-commit if you need some guidance on what to do to make it happen.

…licking the overlay area.

This is an important ability since in some cases we don't want the modal to be closed when users are clicking outside.
Added tests and README instructions.
@dorsha
Copy link
Contributor Author

dorsha commented Mar 25, 2016

@claydiffrient - now it appears as a single commit.

@dorsha
Copy link
Contributor Author

dorsha commented Mar 26, 2016

Thanks @claydiffrient, do you have an estimation about the new release? (I want to use it in my project.)

@claydiffrient
Copy link
Contributor

@dorsha I think we'll shoot for a release the end of next week. There is a large backlog of pull requests and issues that I want to try and work into it if possible.

@dorsha
Copy link
Contributor Author

dorsha commented Mar 26, 2016

Cool 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants