New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixed] Prevent default behavior of ESC key #132

Merged

claydiffrient merged 1 commit into reactjs:master from shunjikonishi:shunjikonishi-patch-1

Mar 24, 2016

Contributor

shunjikonishi commented Mar 2, 2016

Following problem is happened in my app.

Close modal with ESC key
HttpRequest which runs after closing modal is canceled
- Because of ESC key


          Prevent default behavior of ESC key

ef02e29

Contributor

claydiffrient commented Mar 24, 2016

@shunjikonishi Looks simple enough, normally I'd prefer a spec for code changes, but a test in this case would be a little overkill perhaps.

claydiffrient merged commit 980ad5d into reactjs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet