Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] Allow empty classNames for body #720

Merged
merged 2 commits into from
Dec 10, 2018
Merged

Conversation

jitinmaher
Copy link
Contributor

@jitinmaher jitinmaher commented Dec 1, 2018

Fixes #[664] and #[721].

#[664]: This PR allows empty classNames for body and portal when bodyOpenClassName is set with no value( null or "" )

#[721]: The PR also regenerates package-lock.json which fixes event-stream-3.3.6 issue caused because of the recent security incident

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@jitinmaher jitinmaher changed the title Allow empty classNames for body [fixed] Allow empty classNames for body Dec 1, 2018
@jitinmaher
Copy link
Contributor Author

jitinmaher commented Dec 1, 2018

@diasbruno Not sure why build is failing. Following is the error from travis ci:

npm ERR! code E404
npm ERR! 404 Not Found: [email protected]

Could this be related to the event-stream incident ?

Issue reported here

@diasbruno
Copy link
Collaborator

@jitinmaher Thanks for working on this.
Yep, that seems to be the case.
The only thing missing is to update the documentation and, once we have the tests passing, we can merge this PR.

@jitinmaher
Copy link
Contributor Author

Thanks for the review @diasbruno . I have updated the documentation.

@diasbruno
Copy link
Collaborator

Good job. I believe the only page left to update is the docs/README.md.

@jitinmaher
Copy link
Contributor Author

@diasbruno docs/README.md has been Updated 👍

@jitinmaher
Copy link
Contributor Author

@diasbruno Updated the lock file to fix the event-stream issue. Builds and test cases are passing 👍.

@diasbruno
Copy link
Collaborator

Good job, @jitinmaher! I'll finish the review later and merge this. Probably, I'll release a new version tomorrow.

@jitinmaher
Copy link
Contributor Author

Thanks @diasbruno . Looking forward for the new version!!

@jitinmaher
Copy link
Contributor Author

Hey @diasbruno , any updates on the merge?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.56% when pulling f5dd570 on jitinmaher:master into 8d8f476 on reactjs:master.

@jitinmaher
Copy link
Contributor Author

Ping @diasbruno

Sorry to bother you again. Any update on the merge?

@diasbruno
Copy link
Collaborator

No problem, @jitinmaher...actually, thanks for remind me to do it.

@diasbruno diasbruno merged commit 2ae092a into reactjs:master Dec 10, 2018
@diasbruno
Copy link
Collaborator

diasbruno commented Dec 10, 2018

@jitinmaher thank you for having a look on this issue and for your patience to merge this. Good job!

@jitinmaher
Copy link
Contributor Author

@diasbruno Thank you so much for the merge 👍

@diasbruno
Copy link
Collaborator

Released version 3.7.1.

@jitinmaher
Copy link
Contributor Author

Thanks for the version update @diasbruno 🙂

programmer4web pushed a commit to programmer4web/react-modal that referenced this pull request Oct 5, 2020
* [fixed] Allow empty classNames for body

* Regenerate package-lock.json to fix event stream issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to pass an empty class name
3 participants