-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fixed] Allow empty classNames for body #720
Conversation
31aa43f
to
2b52cd1
Compare
@diasbruno Not sure why build is failing. Following is the error from travis ci:
Could this be related to the event-stream incident ? Issue reported here |
@jitinmaher Thanks for working on this. |
Thanks for the review @diasbruno . I have updated the documentation. |
Good job. I believe the only page left to update is the docs/README.md. |
@diasbruno docs/README.md has been Updated 👍 |
@diasbruno Updated the lock file to fix the event-stream issue. Builds and test cases are passing 👍. |
Good job, @jitinmaher! I'll finish the review later and merge this. Probably, I'll release a new version tomorrow. |
Thanks @diasbruno . Looking forward for the new version!! |
Hey @diasbruno , any updates on the merge? |
Ping @diasbruno Sorry to bother you again. Any update on the merge? |
No problem, @jitinmaher...actually, thanks for remind me to do it. |
@jitinmaher thank you for having a look on this issue and for your patience to merge this. Good job! |
@diasbruno Thank you so much for the merge 👍 |
Released version 3.7.1. |
Thanks for the version update @diasbruno 🙂 |
* [fixed] Allow empty classNames for body * Regenerate package-lock.json to fix event stream issue
Fixes #[664] and #[721].
#[664]: This PR allows empty classNames for body and portal when
bodyOpenClassName
is set with no value(null or ""
)#[721]: The PR also regenerates package-lock.json which fixes event-stream-3.3.6 issue caused because of the recent security incident
Acceptance Checklist:
CONTRIBUTING.md
.