[added] Introduce onAfterClose callback prop #724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #708 .
Since the
onRequestClose
won't be executed whenisOpen
changes outside of the controller scope, I think it's reasonable to give a single handler to general closing.This would allow for some more centralised solutions like:
whereas today you have to do:
Changes proposed:
onAfterClose
callback propUpgrade Path (for changed or removed APIs):
Acceptance Checklist:
CONTRIBUTING.md
.