-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package.json): mark react-transition-group as side-effect free for webpack tree shaking #472
Conversation
…r webpack tree shaking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thank you!!!
## [2.6.1](v2.6.0...v2.6.1) (2019-03-14) ### Bug Fixes * **package.json:** mark react-transition-group as side-effect free for webpack tree shaking ([#472](#472)) ([b81dc89](b81dc89))
🎉 This PR is included in version 2.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@setsun @silvenon Unfortunately this doesn't have any effect because react-transition-group only ships a CommonJS build. It would have to also ship an ESM build (and point to it with the |
Ah interesting, that's good to know. This may warrant a follow up PR |
Actually, #455 already adds ESM (but it was missing |
## [2.6.1](reactjs/react-transition-group@v2.6.0...v2.6.1) (2019-03-14) ### Bug Fixes * **package.json:** mark react-transition-group as side-effect free for webpack tree shaking ([#472](reactjs/react-transition-group#472)) ([b81dc89](reactjs/react-transition-group@b81dc89))
## [2.6.1](reactjs/react-transition-group@v2.6.0...v2.6.1) (2019-03-14) ### Bug Fixes * **package.json:** mark react-transition-group as side-effect free for webpack tree shaking ([#472](reactjs/react-transition-group#472)) ([b81dc89](reactjs/react-transition-group@b81dc89))
## [2.6.1](reactjs/react-transition-group@v2.6.0...v2.6.1) (2019-03-14) ### Bug Fixes * **package.json:** mark react-transition-group as side-effect free for webpack tree shaking ([#472](reactjs/react-transition-group#472)) ([b81dc89](reactjs/react-transition-group@b81dc89))
## [2.6.1](reactjs/react-transition-group@v2.6.0...v2.6.1) (2019-03-14) ### Bug Fixes * **package.json:** mark react-transition-group as side-effect free for webpack tree shaking ([#472](reactjs/react-transition-group#472)) ([b81dc89](reactjs/react-transition-group@b81dc89))
What
Add
"sideEffects": false
topackage.json
to hint towebpack
based workflows that the package is side effect free. This allowsreact-transition-group
to allow tree-shaking of its modules.Reference: https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free